Skip to content

[skip ci] fix stalebot #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2019
Merged

[skip ci] fix stalebot #476

merged 1 commit into from
Nov 13, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Nov 8, 2019

Invert the time windows, otherwise an issue will be re-marked stale every 15 days, resetting the time window and preventing the closing event (time window is 30 days) to kick in.

With this patch, when it's the case an issue will be closed before it's re-marked stale.

A more comprehensive solution would be filtering out stale issues but that'd require another loop, let's apply this quick fix while we evaluate how useful is the bot.

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masci masci merged commit dfba10a into master Nov 13, 2019
@masci masci deleted the massi/stalefix branch November 13, 2019 09:53
@rsora rsora mentioned this pull request May 12, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants